tidyverse / dtplyr

Data table backend for dplyr
https://dtplyr.tidyverse.org
Other
665 stars 58 forks source link

Circular dependency bewteen dplyr and dtplyr preventing install #29

Closed zachary-foster closed 8 years ago

zachary-foster commented 8 years ago

When I try to install dtplyr, I get the following:

> devtools::install_github("hadley/dtplyr")
Downloading GitHub repo hadley/dtplyr@master
from URL https://api.github.com/repos/hadley/dtplyr/zipball/master
Installing dtplyr
Downloading GitHub repo hadley/dplyr@master
from URL https://api.github.com/repos/hadley/dplyr/zipball/master
Installing dplyr
Downloading GitHub repo hadley/dtplyr@master
from URL https://api.github.com/repos/hadley/dtplyr/zipball/master
Installing dtplyr
Downloading GitHub repo hadley/dplyr@master
from URL https://api.github.com/repos/hadley/dplyr/zipball/master
Installing dplyr
Downloading GitHub repo hadley/dtplyr@master
from URL https://api.github.com/repos/hadley/dtplyr/zipball/master
Installing dtplyr
Downloading GitHub repo hadley/dplyr@master
from URL https://api.github.com/repos/hadley/dplyr/zipball/master
...

This never completes and I have to stop the command.

Could this be due to the two packages referencing each other in "remotes"?

https://github.com/hadley/dplyr/blob/master/DESCRIPTION#L41

https://github.com/hadley/dtplyr/blob/master/DESCRIPTION#L25

Should devtools perhaps throw an error when this kind of thing happens?

Thanks for all of the great packages by the way!

> sessionInfo()
R version 3.2.3 (2015-12-10)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu precise (12.04.5 LTS)

locale:
 [1] LC_CTYPE=en_CA.UTF-8       LC_NUMERIC=C               LC_TIME=en_CA.UTF-8        LC_COLLATE=en_CA.UTF-8    
 [5] LC_MONETARY=en_CA.UTF-8    LC_MESSAGES=en_CA.UTF-8    LC_PAPER=en_CA.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_CA.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] httr_1.1.0          metacoder_0.0.1.526 R6_2.1.2            tools_3.2.3         withr_1.0.1         curl_0.9.7         
 [7] memoise_1.0.0       git2r_0.15.0        digest_0.6.9        devtools_1.11.1    
hadley commented 8 years ago

This is fixed in the dev version of devtools - we'll be pushing an update to CRAN soon!

zachary-foster commented 8 years ago

Ok, thanks!