search

tidyverse / dtplyr

Data table backend for dplyr
https://dtplyr.tidyverse.org
Other
670 stars 57 forks source link

Use intermediate variable in `slice()` #378

Closed markfairbanks closed 2 years ago

markfairbanks commented 2 years ago

See #377

markfairbanks commented 2 years ago

Good for review.

Also does anyone have an idea what this check failure is caused by? 🤷‍♂️

eutwt commented 2 years ago

My guess is that since the output of expr({...}) has a "srcref" attribute, covr treats it as a separate source file to check. You can either use call2 instead (whose output doesn't have that attribute) or use i <- rlang::zap_srcref(i) after to get rid of the attribute.

markfairbanks commented 2 years ago

Thanks for figuring out that test @eutwt 😄