Closed eutwt closed 2 years ago
Another option would be to just delete lines 80-82. I think the only situation it affects is a user-supplied data.table pronoun symbol matching an environment variable. So if a user calls mutate(lazydt, y = .N)
and they have .N <- 4
as an environment variable, they get a query like dt[, y := .N]
instead of dt[, y := 4]
.
This seems pretty rare, and when it does happen we're creating behavior that diverges from dplyr. But, maybe people are relying on the existing behavior?
I think you're right - deleting 80-82 would probably be fine. But I think the dt_symbols
approach is the right one to use since it preserves backwards compatibility.
closes #386
Created on 2022-08-15 by the reprex package (v2.0.1.9000)