tidyverse / dtplyr

Data table backend for dplyr
https://dtplyr.tidyverse.org
Other
670 stars 57 forks source link

dtplyr release? #407

Closed hadley closed 1 year ago

hadley commented 1 year ago

Any concern with me doing a dtplyr release? (It's broken by dplyr 1.1.0)

Should this be a patch version or a minor version?

markfairbanks commented 1 year ago

I think it's ready for a minor version. There are a bunch of new functions/bug fixes as well as some performance improvements for select() and arrange().

Only possible negative is .by isn't implemented yet? I don't think that's necessarily a blocker though.

hadley commented 1 year ago

If someone could implement .by soon (maybe in the next week?) I think we could hold off; otherwise I think it's fine to include that in the next minor release.

markfairbanks commented 1 year ago

If someone could implement .by soon (maybe in the next week?) I think we could hold off;

Yeah that should be doable, I'll take a look.

hadley commented 1 year ago

@markfairbanks also would mind giving me a list of what you think the biggest new features are? (i.e. what are the things that I should highlight in the blog post?)

markfairbanks commented 1 year ago

Yep, will do. Also FYI I took an initial pass at .by and I'll have a PR by Friday.

hadley commented 1 year ago

Awesome, thanks!

markfairbanks commented 1 year ago

Here's the list. I grabbed this from the reorganized NEWS from #410. Not sure if all of these should be in the blog post but they're the most notable.

New features

Performance improvements

Minor improvements and bug fixes

hadley commented 1 year ago

Thanks!

I'd suggest moving the last point to a new "breaking changes" heading at the top of the news for this release. I don't think it will affect many people, but it's good to advertise prominently.

markfairbanks commented 1 year ago

Sounds good

hadley commented 1 year ago

Closing this issue and about to open an official release issue.