Better names for `duckplyr_df_from_csv()` and `duckplyr_df_from_parquet()`

tidyverse / duckplyr

A drop-in replacement for dplyr, powered by DuckDB for performance.

https://duckplyr.tidyverse.org/

Other

289 stars 19 forks source link

Better names for `duckplyr_df_from_csv()` and `duckplyr_df_from_parquet()` #210

Open hadley opened 4 months ago

hadley commented 4 months ago

I was thinking that read_csv_lazy() and read_parquet_lazy() might more clearly convey their usage.

hadley commented 2 months ago

Or maybe read_csv_duckplyr() or similar.

I find the current selection of function names to be quite confusing.

DavisVaughan commented 2 months ago

My vote is for read_csv_duckplyr(), just "lazy" as the suffix doesn't feel quite right (too ambiguous?)

But keeping the read_csv_ as the prefix is quite nice for muscle memory with readr and autocomplete

hannes commented 2 months ago

we should also have some functions of output, e.g. write_parquet_duckplyr() or something like that

krlmlr commented 1 month ago

DoD:

[ ] Review duckdbfs API (very similar scope as these functions)
[ ] Add deprecation warnings now
[ ] Release to CRAN
[ ] Find names and agree
[ ] Rename

hannes commented 1 month ago

happy with read_*_duckplyr

krlmlr commented 1 month ago

DoD:

[ ] Review duckdbfs API (very similar scope as these functions)
[ ] Find names and agree
[ ] Add deprecation warnings
[ ] Implement with new names
[ ] Add an argument to disable automatic materialization
[ ] Release to CRAN

krlmlr commented 2 weeks ago

Let's go with the full lifecycle changes. We now also have the infrastructure to disable automatic materialization, this seems most useful when reading directly from a file, and will provide an incentive to use the new functions. This needs #255.

I wonder if the new functions should turn auto-mat on or off by default.