tidyverse / duckplyr

A drop-in replacement for dplyr, powered by DuckDB for performance.
https://duckplyr.tidyverse.org/
Other
288 stars 19 forks source link

Review TPCH runs #284

Open krlmlr opened 1 month ago

krlmlr commented 1 month ago

Query 10 didn't finish on my machine for sf=1. I suspect this is due to our use of the "full compatibility" operators from the rfuns extension for comparison. We might want to use faster variants in "good" cases (e.g., compare a column with a constant) so that duckdb can optimize.

Related: #270, CC @toppyy.

krlmlr commented 2 weeks ago

All good now, this was due to undesired materialization, #289.