tidyverse / ggplot2

An implementation of the Grammar of Graphics in R
https://ggplot2.tidyverse.org
Other
6.46k stars 2.02k forks source link

Clarify documentation in mpg: very minor #3477

Closed MaraAlexeev closed 5 years ago

MaraAlexeev commented 5 years ago

I was working through exercises using mpg in ggplot2 Elegant Graphics for Data Analysis, and I got stuck on trying to figure out what a drive train was.

I finally realized the variable drv means drive train. Could the documentation be updated to identify drv as meaning drive train?

Currently: drv f = front-wheel drive, r = rear wheel drive, 4 = 4wd

Suggested: drv the type of drive train, where f = front-wheel drive, r = rear wheel drive, 4 = 4wd

yutannihilation commented 5 years ago

Thanks, sounds good to me. Do you want to try to create a pull request? You need to modify R/data.R and regenerate the doc by devtools::document().

https://github.com/tidyverse/ggplot2/blob/b8420241309c8eea00d7086002c01cdf38a50eac/R/data.R#L103

MaraAlexeev commented 5 years ago

I will! Thanks.

On Sat, Aug 17, 2019 at 4:03 AM Hiroaki Yutani notifications@github.com wrote:

Thanks, sounds good to me. Do you want to try to create a PR? You need to modify R/data.R and regenerate the doc by devtools::document().

https://github.com/tidyverse/ggplot2/blob/b8420241309c8eea00d7086002c01cdf38a50eac/R/data.R#L103

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tidyverse/ggplot2/issues/3477?email_source=notifications&email_token=AJOV6YMQAQR63ATFKE4MET3QE6WG3A5CNFSM4IJ3IXTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QF7HA#issuecomment-522215324, or mute the thread https://github.com/notifications/unsubscribe-auth/AJOV6YII7WAO7NEAIVTNTNTQE6WG3ANCNFSM4IJ3IXTA .

lock[bot] commented 4 years ago

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/