search

tidyverse / ggplot2

An implementation of the Grammar of Graphics in R
https://ggplot2.tidyverse.org
Other
6.48k stars 2.02k forks source link

Update facet_wrap (adjsut the strip position for each panel when strip.placement is "outside") #5934

Open junjunlab opened 3 months ago

junjunlab commented 3 months ago
  1. Making sure the strip.switch.pad.wrap works when strip.placement=outside and strip.position="top".
  2. Giving same gap between the strip and panel when strip.position is "left"/"right" or when nrow>2.
teunbrand commented 3 months ago

Hi, thanks for putting together a PR! If I read the code correctly, this change applies the padding regardless of whether an axis is placed between the panel and the strip, right? If so, that breaks with what is documented for the strip.switch.pad.* arguments. Would you mind opening an issue first describing the problem you are interested in solving? This way, we may be able to discuss and better guide a contribution.

junjunlab commented 3 months ago

Sure, I will open an issue now. Thanks for your replying.