search

tidyverse / haven

Read SPSS, Stata and SAS files from R
https://haven.tidyverse.org
Other
424 stars 117 forks source link

Tidyverse upkeep #673

Closed gorcha closed 2 years ago

gorcha commented 2 years ago

This PR makes a bunch of tidyverse upkeep changes, closing #672 and #661.

The condition formatting write-up in rlang recommends using cli::cli_abort() instead of rlang::abort(), but it's relatively new so I'm a bit unsure about replacing all the error messaging with it yet (it would move cli from suggests to imports and need >=3.0.0) - what do you think?

hadley commented 2 years ago

It's fine to move directly to cli_abort() if you want to. It makes it much easier to construct error messages since you can use glue.

gorcha commented 2 years ago

OK cool, have done! I think we're ready for release once this is merged.

gorcha commented 2 years ago

No worries at all :slightly_smiling_face:

And yep, shall do!