Fix condition expectations in prevision of testthat breaking change

tidyverse / hms

A simple class for storing time-of-day values

https://hms.tidyverse.org/

Other

138 stars 25 forks source link

Fix condition expectations in prevision of testthat breaking change #101

Closed lionel- closed 3 years ago

lionel- commented 3 years ago

We are planning a breaking change to the condition expectations in testthat release (see NEWS item in https://github.com/r-lib/testthat/pull/1401). This PR implements a preventive fix that works with and without the breaking change.

There is no hurry to get this fix on CRAN since we are skipping one released version of testthat before going through with the change.

hadley commented 3 years ago

We're planning on releasing to CRAN soon, so I'd really appreciate it if you could do a release so we avoid breaking a CRAN check for your package 😄

krlmlr commented 3 years ago

Releasing today.

krlmlr commented 3 years ago

Thanks!

krlmlr commented 3 years ago

hms 1.1.1 on CRAN now.