search

tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

Fix lubridate test #23

Closed vspinu closed 8 years ago

vspinu commented 8 years ago

Found this in the latest revdep check on the upcomming lubridate v1.6.0.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #23 into master will not change coverage

@@           master   #23   diff @@
===================================
  Files           3     3          
  Lines          57    57          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           57    57          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 98d14cf...1a49170

krlmlr commented 8 years ago

Thanks! Does the check break entirely, will I need to update hms on CRAN soon?

vspinu commented 8 years ago

Yes. It's a testhat error. I will upload lubridate and inform CRAN folks about the nature of the issue and that the issue has been fixed.