tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

can hms handle milliseconds? #33

Closed randomgambit closed 7 years ago

randomgambit commented 7 years ago

I am using hms to parse the time (hour, minutes, seconds, milliseconds) from timestamps in my data. Unfortunately, I notice that hms seems to forget about the millisecond part of a time (in character format).

> as.hms("12:34:56")
12:34:56
> as.hms("12:34:56.542")
12:34:56
> options(digits.secs=3)
> as.hms("12:34:56.542")
12:34:56

Is that a bug? Having milliseconds is important because I sort the data according to time...

krlmlr commented 7 years ago

Thanks for reporting!

krlmlr commented 7 years ago

Fixed in the development version.

randomgambit commented 7 years ago

you re welcome!. I am an hardcore user of intraday timestamps, so im happy to report any bugs. When are the updates expected to be on CRAN? I cannot use devtools at work (need to install from zip)

krlmlr commented 7 years ago

No ETA yet. Can you build a .tar.gz at home using R CMD build?

randomgambit commented 7 years ago

never done so. how can I do that?

krlmlr commented 7 years ago

Download or clone the repository from GitHub, extract, and run R CMD build . from the terminal.

github-actions[bot] commented 3 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.