search

tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

fixes #37 #41

Closed qgeissmann closed 7 years ago

qgeissmann commented 7 years ago

We can now use c(hms(1), hms(2)) and get a hms object back. c(hms(1), NA) will not work because it is not implemented is base's difftime. So relevant unittest commented out for now. Should be another issue.

codecov[bot] commented 7 years ago

Codecov Report

Merging #41 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   98.63%   98.64%   +0.01%     
==========================================
  Files           6        6              
  Lines          73       74       +1     
==========================================
+ Hits           72       73       +1     
  Misses          1        1
Impacted Files Coverage Δ
R/hms.R 97.36% <100%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f4eaa3...e336389. Read the comment docs.

krlmlr commented 7 years ago

Are you still planning to expand on this?

qgeissmann commented 7 years ago

Yes, sorry, was quite busy in the last few weeks. I will finish this next week if it is ok.

krlmlr commented 7 years ago

No worries. We should keep #42 in mind, too.

krlmlr commented 7 years ago

Thanks!