search

tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

Pillar support #43

Closed krlmlr closed 7 years ago

krlmlr commented 7 years ago

Requires hadley/colformat#38.

Test output: https://travis-ci.org/tidyverse/hms/jobs/271835256#L1906

krlmlr commented 7 years ago

Added a test for hms with 1000 hours.

hadley commented 7 years ago

Looks good and NA placement is much better.

codecov[bot] commented 7 years ago

Codecov Report

Merging #43 into master will increase coverage by 0.56%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #43      +/-   ##
=========================================
+ Coverage   98.63%   99.2%   +0.56%     
=========================================
  Files           6       7       +1     
  Lines          73     125      +52     
=========================================
+ Hits           72     124      +52     
  Misses          1       1
Impacted Files Coverage Δ
R/format.R 100% <100%> (ø) :arrow_up:
R/colformat.R 100% <100%> (ø)
R/arith.R 100% <100%> (ø) :arrow_up:
R/hms.R 97.36% <100%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f4eaa3...24521de. Read the comment docs.