search

tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

#40 #44

Closed qgeissmann closed 3 years ago

qgeissmann commented 7 years ago

Drafted a patch for #40 and #14. Sorry, the first commits are related to #37, I was not sure if I should merge both branches...

codecov[bot] commented 7 years ago

Codecov Report

Merging #44 into master will decrease coverage by 1.92%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage   98.63%   96.7%   -1.93%     
=========================================
  Files           6       7       +1     
  Lines          73      91      +18     
=========================================
+ Hits           72      88      +16     
- Misses          1       3       +2
Impacted Files Coverage Δ
R/hms.R 97.36% <100%> (+0.07%) :arrow_up:
R/dhms.R 88.23% <88.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f4eaa3...38d154c. Read the comment docs.

krlmlr commented 7 years ago

Can you please merge master into your branch, or perhaps rebase and force-push? This will remove the commits that are already merged from the diff.

krlmlr commented 7 years ago

This will also need pillar support (see #43), either as a separate PR or as part of this PR.

krlmlr commented 3 years ago

Thanks for working on this. We could support a dhms class, I can't spend time on finishing this or maintaining this further. Closing for now, please open a new pull request if this is still desired.