#39

[qgeissmann]

My attempt at rewriting the parser (issue #39).

So now, this should work:

time_str <- c("12:34:56",         # regular format
              "12:34:56.789",     # decimal points
              "20:12",            # HH:MM (no seconds)
              "-12:34:56.001",    # negative values without days
              "1d 12:34:56",      # number of days (integer)
              "1d 12:34:56.001",  # decimal points and days
              "-1d 12:34:56.001", # negative values
              "-1d 12:34:56.001", # negative values and space
              "0.5d",             # day only
              NA                  # NA
)

In addition,

• I removed parse_hm(), we could just alias it.
• A problem attribute is added to the result when issues were encountered (see tests)
• The whole thing is probably much less efficient, and I have not measured how bad it is on large vectors...

[codecov[bot]]

Codecov Report

Merging #45 into master will decrease coverage by 2.45%. The diff coverage is 94.18%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   98.63%   96.17%   -2.46%     
==========================================
  Files           6        6              
  Lines          73      157      +84     
==========================================
+ Hits           72      151      +79     
- Misses          1        6       +5

Impacted Files	Coverage Δ
R/hms.R	97.36% <100%> (+0.07%)	:arrow_up:
R/parse.R	94.11% <94.11%> (-5.89%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f4eaa3...03b0948. Read the comment docs.

[krlmlr]

Thanks for working on this. Let's leave better parsing to other packages.