tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

vctrs support #66

Closed krlmlr closed 5 years ago

krlmlr commented 5 years ago

Part of #61.

Currently missing:

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d77601d). Click here to learn what that means. The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   92.57%           
=========================================
  Files             ?        9           
  Lines             ?      175           
  Branches          ?        0           
=========================================
  Hits              ?      162           
  Misses            ?       13           
  Partials          ?        0
Impacted Files Coverage Δ
R/round.R 100% <100%> (ø)
R/parse.R 100% <100%> (ø)
R/arith.R 100% <100%> (ø)
R/coerce.R 60% <60%> (ø)
R/cast.R 77.27% <77.27%> (ø)
R/hms.R 95.91% <96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d77601d...6d1cafd. Read the comment docs.

krlmlr commented 5 years ago

@hadley: Would you like to take another look?