search

tidyverse / hms

A simple class for storing time-of-day values
https://hms.tidyverse.org/
Other
138 stars 25 forks source link

Use maybe_lossy_cast() #68

Closed krlmlr closed 3 years ago

krlmlr commented 5 years ago

in vec_cast.hms.character() as soon as it becomes available.

krlmlr commented 3 years ago

Now allow_lossy_cast(), available since vctrs 0.2.0 .

krlmlr commented 3 years ago

maybe_lossy_cast() also exists.

@lionel-: Are you planning substantial changes to maybe_lossy_cast()? Is it safe to use here?

lionel- commented 3 years ago

I would say this is a more experimental area of vctrs. It doesn't seem to be very useful either. Do you really need this? I would avoid throwing lossy cast conditions and just throw coercion errors personally. That said if you really need it go ahead, there are no changes planned now (but vctrs is not under active dev at the moment).

krlmlr commented 3 years ago

Thanks, throwing an error now.

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.