search

tidyverse / lubridate

Make working with dates in R just that little bit easier
https://lubridate.tidyverse.org
GNU General Public License v3.0
731 stars 207 forks source link

`use_z_format` argument added to `format_ISO8601()` #1022

Closed billdenney closed 2 years ago

billdenney commented 2 years ago

Fix #941

Adds a use_z_format argument to format_ISO8601() and does some code style reformatting within the same file.

vspinu commented 2 years ago

Thanks, but this PR has a lot of white-space changes and it's dificult for me to judge what is actually changed.

Regarding the name, would it be ok to use z_format = instead of use_z_format. We can also reuse usetz = "Z" argument. I think I would prefer the later option.

billdenney commented 2 years ago

Sorry about the whitespace changes. I tried to put them into the first commit because I saw that lines were getting pretty long. But because some of the other code changes were already in place, the first commit does have a few other changes related to documentation. If helpful, I can redo the PR without the whitespace changes.

Good call on the name. I revised to usetz="Z".

vspinu commented 2 years ago

There are failures. Hadley is working on a new workflow, hopefully those are gone once done. Will merge this one once that works has been done.

januz commented 2 years ago

When is this planned to be merged? Thanks!

vspinu commented 2 years ago

@billdenney I made a few small changes and removed all the extraneous formatting which didn't match our house rules.

Thanks!

billdenney commented 2 years ago

Thanks for the effort to get it in!