We now store the names on the column that corresponds to the @.Data slot of the original object. For Period this is $second and for Interval this is $span. This fixes the problem of #1072 because it means that we never have a mismatch in the number of columns that are on the proxy.
A few extra niceties here:
No need for compare/equal proxy methods anymore, we just carry around the names unconditionally, which doesn't hurt anything
No need for the complicated recursive proxying done in the Interval methods, because in vctrs 0.5.0 if a data frame is returned as the proxy then it will automatically proxy the columns recursively too (CC @lionel- this is a nice side effect of that change we made)
Closes #1072
We now store the names on the column that corresponds to the
@.Data
slot of the original object. For Period this is$second
and for Interval this is$span
. This fixes the problem of #1072 because it means that we never have a mismatch in the number of columns that are on the proxy.A few extra niceties here: