search

tidyverse / lubridate

Make working with dates in R just that little bit easier
https://lubridate.tidyverse.org
GNU General Public License v3.0
728 stars 207 forks source link

Can timechange be in Imports, not Depends? #1090

Closed DavisVaughan closed 1 year ago

DavisVaughan commented 1 year ago

I don't think there is any reason it should be in Depends, right? It forces lubridate to show this message when it is loaded

library(lubridate, warn.conflicts = FALSE)
#> Loading required package: timechange

We generally prefer putting packages in Imports unless there is a really compelling reason not to

vspinu commented 1 year ago

yes. it was a mistake.

On Wed, Nov 9, 2022, 17:55 Davis Vaughan @.***> wrote:

I don't think there is any reason it should be in Depends, right? It forces lubridate to show this message when it is loaded

library(lubridate, warn.conflicts = FALSE)#> Loading required package: timechange

We generally prefer putting packages in Imports unless there is a really compelling reason not to

— Reply to this email directly, view it on GitHub https://github.com/tidyverse/lubridate/issues/1090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKM4C6ECRT6TL5YBTUFQTDWHPJO7ANCNFSM6AAAAAAR3UQMHI . You are receiving this because you are subscribed to this thread.Message ID: @.***>