Open asadow opened 10 months ago
Adding to this issue since I found round_date()
documentation a bit lacking today.
I was trying to ascertain what unit
s get affected by the week_start
parameter, with the suspicion that it's only unit="week"
, but was unable to confirm this until I looked at the source code, which pointed me to timechange::time_round()
which documentation does confirm this:
Maybe the documentation should just point directly to [timechange::time_round()]
instead?
I'd like to re-open a discussion surrounding the parameter
week_start
's description. Currently it is,Perhaps going straight into an example and removing unnecessary detail is the simplest way to explain this parameter. Something like,
Three other suggestions:
day
. This capitalization style is from the tidyverse style guide on the subject.wday
are not referred to aswday()
but aswday
(e.g. in the description for parameterlabel
). May we add parentheses after every function mentioned in the descriptions? This suggestion is also from the style guide. Likewise with backticking functions and values.label
. The suggested description (second above) is more clear, but still suffers from the two sets of return values. From #1100 and #866 I gather there are historical reasons. Which leads me to the question: would an additional function likeweekday()
be appropriate to help circumvent historical reasons for thiswday()
's confusion?