Open brunj7 opened 4 years ago
Worse than the fact that they're inconsistent is that both are fail-silent.
This is actually a very useful feature to have a rollover, but it is surprising at first and you cannot disable it.
IMHO, there should be a rollover=TRUE
parameter to opt-in in both functions.
related to #839
make_date
andmake_datetime
are not consistent when out of range values are passed as parameters.make_date
will generate NA,make_datetime
will rollover silentlyCreated on 2020-01-31 by the reprex package (v0.3.0.9001)