tidyverse / modelr

Helper functions for modelling
https://modelr.tidyverse.org
GNU General Public License v3.0
401 stars 66 forks source link

Default geom_ref_line colour to panel.grid.major #56

Closed jongbinjung closed 6 years ago

jongbinjung commented 7 years ago

Use the current theme's panel.grid.major color for geom_ref_line, which seems to be better than defaulting to "white".

I use this a lot with theme_bw(), and it's a bit annoying to specify colour = "grey92" everytime ...

hadley commented 6 years ago

That retrieves the default theme, not the theme of the current plot, so I don't think it's a good idea, unfortunately.

jongbinjung commented 6 years ago

Is there a way to use the theme is the current plot?

hadley commented 6 years ago

No, because it might be modified after you add this layer (this is a general draw back to the current design of ggplot2)