search

tidyverse / multidplyr

A dplyr backend that partitions a data frame over multiple processes
https://multidplyr.tidyverse.org
Other
641 stars 75 forks source link

update github actions #129

Closed romainfrancois closed 2 years ago

romainfrancois commented 2 years ago

I tried to make it depend on R 3.4 as in #114, but there seems to be an issue building stringfish. cc @traversc

https://github.com/tidyverse/multidplyr/runs/4368543258?check_suite_focus=true#step:5:378

traversc commented 2 years ago

Sorry, it should be fixed now (again). https://github.com/traversc/stringfish/runs/4377875621?check_suite_focus=true#step:7:120

There was a simple macro issue where I forgot to define a function in R < 3.5. I thought I tested R 3.4, but at some point oldrel-3 changed to R 3.5 :P

romainfrancois commented 2 years ago

Thanks @traversc, will you release stringfish to cran ?

traversc commented 2 years ago

Updated on CRAN.

hadley commented 2 years ago

Thanks @traversc, added in #130.