search

tidyverse / multidplyr

A dplyr backend that partitions a data frame over multiple processes
https://multidplyr.tidyverse.org
Other
641 stars 75 forks source link

multidplyr throws warning when used with dplyr 0.7.0 #57

Closed hokerl closed 5 years ago

hokerl commented 7 years ago

Using multidplyr with dplyr 0.7.0 generates the following warning: group_indices_.grouped_df ignores extra arguments

Minimal example: mtcars %>% partition(cyl) %>% collect()

It seems to have no impact on the calculated results, but I am not sure if that's always the case...

MGousseff commented 7 years ago

I encounter this problem as well. Thought it did no harm, but I do get problems in a more complex function... Could it be linked to the weird if condition in the group_indices.grouped_df function : if(length(list(...)) ?

Please don't burn me if this is just something I didn't understand, as I am so grateful that these tools exist.

Ilia-Kosenkov commented 5 years ago

I found the source of the warning. It happens in the call group_id <- dplyr::group_indices_(data), line 47 in shard.R, which in turn throws in group_indices.grouped_df, line 62 in dplyr/group-indices.R. Here is a reprex:

dplyr::group_indices_(dplyr::group_by_(mtcars, "gear"))
#> Warning: group_indices_.grouped_df ignores extra arguments
#>  [1] 2 2 2 1 1 1 1 2 2 2 2 1 1 1 1 1 1 2 2 2 1 1 1 1 1 2 3 3 3 3 3 2

Created on 2018-11-15 by the reprex package (v0.2.1.9000)

Unfortunately, no idea how to fix it.

hadley commented 5 years ago

This appears to be fixed by latest updates.