search

tidyverse / rvest

Simple web scraping for R
https://rvest.tidyverse.org
Other
1.49k stars 341 forks source link

skip tests requiring webfakes #346

Closed MichaelChirico closed 7 months ago

hadley commented 2 years ago

Would you mind explaining the root problem?

MichaelChirico commented 2 years ago

pretty simple: webfakes is unavailable 🙂

hadley commented 2 years ago

And what's the root cause of that? 😆

MichaelChirico commented 2 years ago

two main things:

  1. there's manual overhead for us to bring in incremental packages -- https://opensource.google/documentation/reference/thirdparty. so unless we need Suggests functionality, we usually don't import those deps (e.g. just to pass a small # of tests)
  2. our test infra blocks web calls. i'm not sure webfakes even can work (speculative -- haven't looked into webfakes much)

we have already applied the patch to our fork, but filed here as well thinking it's more generally useful. but do feel free to close.

hadley commented 2 years ago

Thanks! Just wanted to understand the root context; I'll likely merge when I'm next working on testthat.