search

tidyverse / rvest

Simple web scraping for R
https://rvest.tidyverse.org
Other
1.49k stars 341 forks source link

Check exclusive #375

Closed jonthegeek closed 7 months ago

jonthegeek commented 1 year ago

Closes #374

I updated all other errors in make_selector() to what I believe to be the current preferred style, but did not update everything in find_href() in case I'm wrong about the preference.

jonthegeek commented 7 months ago

I can finish it off in a day or two!

I'll need to remember why I made those changes you called out to see if I want to argue for them; right now I can't remember, but I assume I had an argument for them at the time.

I'll likely have more questions about what you want when I get a chance to dig into this!

jonthegeek commented 7 months ago

Should I update the workflow to match something more recently updated (eg httr2) while I'm at it, to kill those ubuntu-18.04 failures?

hadley commented 7 months ago

I don't see the failures on main, so you should just be able to rebase/merge from main.

hadley commented 7 months ago

Actually, I just started converting the error to use cli, so it might be just as easy for me to do check_exclusive() while I'm in here.

jonthegeek commented 7 months ago

Ok, I won't be offended if you go ahead and clear this out without me! I'll be happy to review, and I'll still try to figure out why I felt the need to change other things!

hadley commented 7 months ago

Done in #386. I'm sure there's still plenty of room for improvement though.