tidyverse / stringr

A fresh approach to string manipulation in R
https://stringr.tidyverse.org
Other
603 stars 187 forks source link

str_view_all Shows Incorrect Error Message #537

Closed brownj31 closed 3 months ago

brownj31 commented 10 months ago

The error message in str_view_all() says that str_view() was deprecated. Shouldn't it should say str_view_all() is deprecated?

library(stringr)

str_view('apple', 'a')
#> [1] | <a>pple
str_view_all('apple', 'a')
#> Warning: `str_view()` was deprecated in stringr 1.5.0.
#> i Please use `str_view_all()` instead.
#> This warning is displayed once every 8 hours.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
#> [1] | <a>pple

Created on 2023-11-26 with reprex v2.0.2

hadley commented 3 months ago

Fixed in #490