Post-mortem - Githubissues

tidyverse / tidy-dev-day

Tidyverse developer day

https://rstd.io/tidy-dev-day

76 stars 26 forks source link

Post-mortem #17

Closed jimhester closed 5 years ago

jimhester commented 5 years ago

Not sure if we are collecting notes about the dev day, but I had a couple so I am putting them here.

jimhester commented 5 years ago

Explain the Fixes #123432 syntax
Adding note to NEWS
using devtools::install_dev_deps() when starting work on a repo
the load_all() / test() loop
Not needing ::: in test files
possibly explain / show good examples of commit messages?
Maybe explain document() / .Rd (though most already knew this I think)

jennybc commented 5 years ago

Give same suggestion re: Git/GitHub/RStudio prep as for 2-day workshop participants:

https://happygitwithr.com/workshops.html#pre-workshop-set-up

Would encourage more standard, more up-to-date Git system prep.

Special emphasis on knowing GitHub your password (ie it's not enough that your browser remembers it) and having https credentials cached or ssh keys set up.

jennybc commented 5 years ago

Emphasise fork then clone then create a branch.

hadley commented 5 years ago

styler for tidyverse style
hopefully more sitrep functions for next time

batpigandme commented 5 years ago

Got bunch of helpful feedback from some beginners and will add more, but I think the dearth of structure made it hard for them to get started / feel like it was for them. Will expand, didn't want to lose the immediate knowledge. -- Mara

Mara Averick | maraaverick@gmail.com http://www.linkedin.com/in/maraaverick

jennybc commented 5 years ago

Play some background music? I did that during "your turn" segments in the WTF workshop and I thought it gave those segments a nice, warmer feeling. However, at dev day, there is plenty of background noise and people chatting already ...

jennybc commented 5 years ago

Definitive instructions about magic keywords:

https://help.github.com/articles/closing-issues-using-keywords/

hadley commented 5 years ago

Another problem that hit a few people: assuming you can use any package in the tidyverse. Need to check what the package currently imports first.

jennybc commented 5 years ago

Another problem that hit a few people: assuming you can use any package in the tidyverse. Need to check what the package currently imports first.

This would be easier to give advice for when we make progress on:

use_package should print recursive list of dependencies that will be added https://github.com/r-lib/usethis/issues/310