add "Your first PR" worksheet

tidyverse / tidy-dev-day

Tidyverse developer day

https://rstd.io/tidy-dev-day

76 stars 26 forks source link

add "Your first PR" worksheet #66

Closed EmilHvitfeldt closed 3 months ago

EmilHvitfeldt commented 3 months ago

This PR adds a printable worksheet to help you make your first PR.

I took the readme, embellished, modified it to be more printer friendly, and adding suggestions from @jennybc.

the #v() calls adds vertical spacing to hopefully allow for some room for notes. The top right corner of the first page have plenty of room for a Post-it and notes.

CC @hadley

to close https://github.com/tidyverse/tidy-dev-day/issues/47

EmilHvitfeldt commented 3 months ago

Github doesn't have nice pdf preview, so here is the rendered results:

EmilHvitfeldt commented 3 months ago

Pdf with changes (am quite pleased with the post-it square

EmilHvitfeldt commented 3 months ago

I got confused by the layout:

it is a two-column layout:

0 and 1 on column one,
post-it and 2 on column two,
3 and 4 on column three
5 on column four

I tried introducing some space between sections for notes

jennybc commented 3 months ago

Just in case we're talking past each other, here's the flow that confuses me:

EmilHvitfeldt commented 3 months ago

I think of the flow as 0 -> 1 -> post-it -> 2 etc etc. Since 1 is claiming the issue and finding the post-it. But I'm happy to move it around

EmilHvitfeldt commented 3 months ago

Results so far:

EmilHvitfeldt commented 3 months ago

jennybc commented 3 months ago

I approved a while ago, but I'll reiterate that this LGTM 👍