tidyverse / tidytemplate

A pkgdown template for core tidyverse packages
https://tidytemplate.tidyverse.org
Other
46 stars 22 forks source link

Update footer template and add tidyverse component #62

Closed gadenbuie closed 3 years ago

gadenbuie commented 3 years ago

This PR pairs with r-lib/pkgdown#1870 to use the new pkgdown footer template by removing the custom tidytemplate footer.html, using the package component proposed in the pkgdown PR and updating the template _pkgdown.yml to set the footer structure with a custom tidyverse component.

hadley commented 3 years ago

We're deliberately moving away from this footer because most folks I asked didn't think it was that useful. At some point in the future, we'd replace it with a consistent footer across all open source packages (e.g. r-lib/tidyverse/tidymodels/rmarkdown/shiny) that provided general cross-links (like the footer at the bottom of rstudio.com)

gadenbuie commented 3 years ago

Fair enough. I'm going to close this PR -- in my testing, dev pgkdown ignores the custom footer in tidytemplate and the footer is fully configurable via the _pkgdown.yml file. (Just letting you know in case you were expecting the footer template to be used.)