search

tidyverse / tidytemplate

A pkgdown template for core tidyverse packages
https://tidytemplate.tidyverse.org
Other
46 stars 22 forks source link

ASCII rectangles on pkgdown are off #83

Open krlmlr opened 2 months ago

krlmlr commented 2 months ago

README: https://github.com/tidyverse/duckplyr/?tab=readme-ov-file#usage-for-individual-data-frames

Website: https://duckplyr.tidyverse.org/#usage-for-individual-data-frames

Scroll down a bit.

krlmlr commented 2 months ago

In Firefox I see:

image

krlmlr commented 2 months ago

@maelle: Any idea? This is Firefox only, Safari is better. No idea about other browsers.

maelle commented 2 months ago

To make things worse, it looks good for me on Firefox on Ubuntu

image

hadley commented 2 months ago

My investigation notes at https://github.com/pola-rs/polars/pull/18187#issuecomment-2302077398

maelle commented 1 month ago

so why not use https://github.com/rstudio/keras3/blob/6ff11d22946960439fee830338ffd29422a5b294/pkgdown/_pkgdown.yml#L26-L32?

krlmlr commented 1 month ago

It's not the same style. I've worked around with plain dashes for now, I'd rather fix for good or keep it as is.

When I inspect the code chunk, I see "Font Awesome 6" being mentioned. Is this the same as "Source Code Pro"?

Would it help if we served a more complete version of "Source Code Pro", if https://github.com/google/fonts/issues/4235 turns out to be the issue?

image