search

tidyverse / tidyversedashboard

Tidyverse activity dashboard
https://tidyverse.org/dashboard
Other
72 stars 24 forks source link

Add privacy option? #6

Closed maelle closed 6 years ago

maelle commented 6 years ago

Not sure if generally useful. I used that for Locke Data. Privacy could be "all" (default like now), "private", "public" to query only private/public repos.

Technically it'd mean changing this query by adding privacy e.g. repositories(first:20, affiliations: OWNER, orderBy: {field: PUSHED_AT, direction: DESC}, privacy: PUBLIC, isFork: false, after: $cursor) but it couldn't be parameterized for having all repos: the privacy only accept either PUBLIC or PRIVATE, so there should be some sort of gluing I guess if the privacy isn't "all".

jimhester commented 6 years ago

Alternatively this could be controlled by the permissions you give the personal access token you are using, I am inclined to go that route rather than adding an additional parameter.

But maybe we should return the privacy status of the repo in the table?

Also NB, if you just don't assign the parameter it is not used, so no need to do upstream glueing.

maelle commented 6 years ago

Not sure I follow, would you change your environment variable depending on what you're doing?

Sounds good to return the privacy status!

Good to know about the parameter!

jimhester commented 6 years ago

You were right, this is a good idea, it is now added!

maelle commented 6 years ago

:joy: I might be happier to have been right than to see it added 🙈 Thanks!