tidyverse / vroom

Fast reading of delimited files
https://vroom.r-lib.org
Other
621 stars 60 forks source link

Vroom 1.6.0 fails when passed list of (curl) connections #469

Closed Syntopia closed 1 year ago

Syntopia commented 2 years ago

After upgrading to Vroom 1.6.0, it seems it is no longer possible to pass a list of curl connections - this used to work on 1.5.7.

Passing a list of URLs still works.

library(curl)
library(vroom)
url = "https://people.sc.fsu.edu/~jburkardt/data/csv/addresses.csv"

# Fails - worked with Vroom 1.5.7
t <- vroom(list(curl(url),curl(url)))

# Works
t <- vroom(c(url,url))

The error message in 1.6.0 is:

Error in enc2utf8(path) : argument is not a character vector
hadley commented 1 year ago

I think this must have only worked by accident; it's certainly not documented.

jennybc commented 1 year ago

From my reading, vroom does actually claim to read a list of connections, in both its README and in its Get Started vignette. I'm not re-opening this, though, because it's basically a duplicate of #509, which will soon be addressed by #514.