search

tidyverse / vroom

Fast reading of delimited files
https://vroom.r-lib.org
Other
621 stars 60 forks source link

Align argument types and format strings #524

Closed jennybc closed 12 months ago

jennybc commented 1 year ago

Closes #523

jennybc commented 12 months ago

Checking on Windows with r-devel was revealing. The existing fixes all hold up, but I get some new hits in a totally different file, so I'm happy to learn about this now! I also sent everything to win-builder (devel, release, oldrel) and get completely consistent results: the new warnings seen below on devel, clean pass on release and oldrel.

Found the following significant warnings:
  unicode_fopen.h:52:52: warning: conversion lacks type at end of format [-Wformat=]
  unicode_fopen.h:52:14: warning: too many arguments for format [-Wformat-extra-args]
  unicode_fopen.h:78:52: warning: conversion lacks type at end of format [-Wformat=]
  unicode_fopen.h:78:14: warning: too many arguments for format [-Wformat-extra-args]

Update: I now see these additional warnings also in the CRAN results for windows + r-devel. I think that hadn’t shown up yet when I first got the email (or else I just overlooked it / assumed all flavours were complaining about the same things).