Release vroom 1.6.5 - Githubissues

jennybc commented 11 months ago

Prepare for release:

[x] git pull
[x] Check current CRAN check results
[x] Polish NEWS
[x] urlchecker::url_check()
[x] devtools::build_readme()
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] revdepcheck::cloud_check()
[x] Update cran-comments.md
[x] git push

Submit to CRAN:

[x] usethis::use_version('patch')
[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted :tada:
[x] usethis::use_github_release()
[x] usethis::use_dev_version(push = TRUE)

lorenzoFabbri commented 11 months ago

> pak::pak("tidyverse/vroom")
✔ Updated metadata database: 3.09 MB in 11 files.                          
✔ Updating metadata database ... done                                      

→ Will update 1 package.
→ Will download 1 package with unknown size.
+ vroom 1.6.4 → 1.6.5.9000 [bld][cmp][dl] (GitHub: 788df43)

? Do you want to continue (Y/n) Y
ℹ Getting 1 pkg with unknown size
✔ Got vroom 1.6.5.9000 (source) (2.73 MB)                
✔ Downloaded 1 package (2.73 MB) in 2.7s                 
ℹ Packaging vroom 1.6.5.9000
✔ Packaged vroom 1.6.5.9000 (1m 47.5s)                           
ℹ Building vroom 1.6.5.9000                                      
✖ Failed to build vroom 1.6.5.9000                               
Error:                                                           
! error in pak subprocess
Caused by error in `stop_task_build(state, worker)`:
! Failed to build source package 'vroom'
Full installation output:
* installing *source* package ‘vroom’ ...
staged installation is only possible with locking
** using non-staged installation
** libs
using C compiler: ‘gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0’
using C++ compiler: ‘g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0’
g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -Imio/include -DWIN32_LEAN_AND_MEAN -Ispdlog/include -DFMT_HEADER_ONLY -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/progress/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/tzdb/include'     -fpic  -g -O2 -ffile-prefix-map=/build/r-base-MHXHhT/r-base-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -pedantic -fdiagnostics-color=always -c Iconv.cpp -o Iconv.o
In file included from Iconv.cpp:2
/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include/cpp11/protect.hpp:326:3:warning: cpp11::preservedined but not used [-Wunused-variable
  326 | } preserved
      |   ^~~~~~~~~
g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -Imio/include -DWIN32_LEAN_AND_MEAN -Ispdlog/include -DFMT_HEADER_ONLY -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/progress/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/tzdb/include'     -fpic  -g -O2 -ffile-prefix-map=/build/r-base-MHXHhT/r-base-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -pedantic -fdiagnostics-color=always -c LocaleInfo.cpp -o LocaleInfo.o
g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -Imio/include -DWIN32_LEAN_AND_MEAN -Ispdlog/include -DFMT_HEADER_ONLY -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/progress/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/tzdb/include'     -fpic  -g -O2 -ffile-prefix-map=/build/r-base-MHXHhT/r-base-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -pedantic -fdiagnostics-color=always -c altrep.cc -o altrep.o
g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -Imio/include -DWIN32_LEAN_AND_MEAN -Ispdlog/include -DFMT_HEADER_ONLY -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/progress/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/tzdb/include'     -fpic  -g -O2 -ffile-prefix-map=/build/r-base-MHXHhT/r-base-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -pedantic -fdiagnostics-color=always -c cpp11.cpp -o cpp11.o
g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -Imio/include -DWIN32_LEAN_AND_MEAN -Ispdlog/include -DFMT_HEADER_ONLY -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/progress/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/tzdb/include'     -fpic  -g -O2 -ffile-prefix-map=/build/r-base-MHXHhT/r-base-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -pedantic -fdiagnostics-color=always -c delimited_index.cc -o delimited_index.o
g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -Imio/include -DWIN32_LEAN_AND_MEAN -Ispdlog/include -DFMT_HEADER_ONLY -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/cpp11/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/progress/include' -I'/home/lfabbri/Documents/edu/phd/papers/paper3_helixSC_neuro/paper-helixSC-neuro/renv/library/R-4.3/x86_64-pc-linux-gnu/tzdb/include'     -fpic  -g -O2 -ffile-prefix-map=/build/r-base-MHXHhT/r-base-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -Wall -pedantic -fdiagnostics-color=always -c delimited_index_connection.cc -o delimited_index_connection.o
In file included from /usr/include/c++/11/vector:72
                 from /usr/include/c++/11/functional:62
                 from /usr/include/c++/11/pstl/glue_algorithm_defs.h:13
                 from /usr/include/c++/11/algorithm:74
                 from mio/include/mio/detail/mmap.ipp:28
                 from mio/include/mio/mmap.hpp:490
                 from mio/include/mio/shared_mmap.hpp:24
                 from delimited_index.h:12
                 from delimited_index_connection.h:1
                 from delimited_index_connection.cc:3
/usr/include/c++/11/bits/vector.tcc:n member function ‘void std::vector<_Tp, _Alloc>::_M_realloc_insert(std::vector<_Tp, _Alloc>::iterator, _Args&& ...) [with _Args = {const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&}; _Tp = std::__cxx11::basic_string<char>; _Alloc = std::allocator<std::__cxx11::basic_string<char> >]
/usr/include/c++/11/bits/vector.tcc:505:5:internal compiler error: ntation fault
  505 |     }
      |     ^
0x7f9be9e4251f ???
    ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f9be9e29d8f __libc_start_call_main
    ../sysdeps/nptl/libc_start_call_main.h:58
0x7f9be9e29e3f __libc_start_main_impl
    ../csu/libc-start.c:392
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <file:///usr/share/doc/gcc-11/README.Bugs> for instructions.
make: *** [/usr/lib/R/etc/Makeconf:198: delimited_index_connection.o] Error 1
ERROR: compilation failed for package ‘vroom’
* removing ‘/tmp/Rtmpc9RO4M/pkg-lib3e0e0520edb76/vroom’
Type .Last.error to see the more details.

Using:

> R.version
               _                           
platform       x86_64-pc-linux-gnu         
arch           x86_64                      
os             linux-gnu                   
system         x86_64, linux-gnu           
status                                     
major          4                           
minor          3.1                         
year           2023                        
month          06                          
day            16                          
svn rev        84548                       
language       R                           
version.string R version 4.3.1 (2023-06-16)
nickname       Beagle Scouts

jennybc commented 11 months ago

👆 looks like some problem specific to your system or maybe a corrupt download? Certain lines that catch my eye:

staged installation is only possible with locking
...
/usr/include/c++/11/bits/vector.tcc:n member function ‘void std::vector<_Tp, _Alloc>::_M_realloc_insert(std::vector<_Tp, _Alloc>::iterator, _Args&& ...) [with _Args = {const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&}; _Tp = std::__cxx11::basic_string<char>; _Alloc = std::allocator<std::__cxx11::basic_string<char> >]
/usr/include/c++/11/bits/vector.tcc:505:5:internal compiler error: ntation fault
  505 |     }
      |     ^
0x7f9be9e4251f ???
    ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f9be9e29d8f __libc_start_call_main
    ../sysdeps/nptl/libc_start_call_main.h:58
0x7f9be9e29e3f __libc_start_main_impl
    ../csu/libc-start.c:392
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <file:///usr/share/doc/gcc-11/README.Bugs> for instructions.

Why don't you have file locking? But mainly I am suspicious of the "internal compiler error" message.

vroom 1.6.5 is building and checking fine on the full CI matrix here and on CRAN:

https://github.com/tidyverse/vroom/actions/runs/7118747541

https://cran.r-project.org/web/checks/check_results_vroom.html

tidyverse / vroom

Release vroom 1.6.5 #525