tidyverse / vroom

Fast reading of delimited files
https://vroom.r-lib.org
Other
622 stars 60 forks source link

Fails to compile on R4.4 #538

Open pipedream opened 4 months ago

pipedream commented 4 months ago

Vroom does not compile on R4.4 for me.

I am using Debian 12, gcc 12.2.0, and R4.4 from cran. vroom.log

dtmvandenberg commented 4 months ago

Getting the exact same error messages on Ubuntu 22.04 with gcc 11.4.0 and R 4.4.0.

DavisVaughan commented 4 months ago

Update cpp11 to the CRAN version, i.e. 0.4.7, and try again. That should fix it. See https://github.com/r-lib/cpp11/pull/345

DavisVaughan commented 4 months ago

It looks like you may also need to update the progress package to its CRAN version as well, i.e. 1.2.3, see https://github.com/r-lib/progress/commit/367dbb08df0de71a4de97657726500c35b5be595

pipedream commented 4 months ago

Thank you.

I did NOT need to upgrade either of the Debian 12 packages

All I needed to fix it was: install.packages("progress")

It fetched progress 1.2.3 into /usr/local/lib (in addition to the debian package of progress 1.2.2 in /usr/lib) and then vroom installed.

DavisVaughan commented 4 months ago

You'll still get compilation warnings about cpp11 unless you update that too, but you're right that the logs suggest that the progress case was the one that was causing the error

arne-henningsen commented 4 months ago

So should the "vroom" and "readxl" packages (and perhaps also some other packages) 'depend' on (a certain version of) the "progress" package to avoid this problem? Or could at least the error message be improved so that users who experience the problem can read how they can fix the problem?

jennybc commented 4 months ago

Well, their dependence on a specific version is specific to R 4.4 which just got released. So I think we'll bump the minimum version of progress next time we release. I'm not sure that this alone is worth a release of these packages.

DavisVaughan commented 4 months ago

@jennybc you've actually done that already https://github.com/tidyverse/vroom/pull/526

jennybc commented 4 months ago

I love past me.