tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

ARIMA errors #134

Closed robjhyndman closed 4 years ago

robjhyndman commented 4 years ago
library(fable)
#> Loading required package: fabletools
#> 
#> Attaching package: 'fabletools'
#> The following object is masked from 'package:stats':
#> 
#>     decompose
library(tsibble)

fpp2::gasoline %>%
  as_tsibble() %>%
  model(ARIMA(value ~ fourier(K = 13) + PDQ(0,0,0))) %>%
  forecast(h = "3 years")
#> Registered S3 method overwritten by 'xts':
#>   method     from
#>   as.zoo.xts zoo
#> Registered S3 method overwritten by 'quantmod':
#>   method            from
#>   as.zoo.data.frame zoo
#> Registered S3 methods overwritten by 'forecast':
#>   method             from    
#>   fitted.fracdiff    fracdiff
#>   residuals.fracdiff fracdiff
#> Error: Must pass a scalar integer as `nrow` argument to `new_tibble()`.

USAccDeaths %>% 
  as_tsibble() %>% 
  model(ARIMA(value) ~ PDQ(0,0,0))
#> Error: Model definition(s) incorrectly created: ARIMA(value) ~ PDQ(0, 0, 0)
#> Check that specified model(s) are model definitions.

Created on 2019-11-13 by the reprex package (v0.3.0)

Session info ``` r devtools::session_info() #> ─ Session info ─────────────────────────────────────────────────────────────── #> setting value #> version R version 3.6.1 (2019-07-05) #> os Ubuntu 19.10 #> system x86_64, linux-gnu #> ui X11 #> language en_AU:en #> collate en_AU.UTF-8 #> ctype en_AU.UTF-8 #> tz Australia/Melbourne #> date 2019-11-13 #> #> ─ Packages ─────────────────────────────────────────────────────────────────── #> package * version date lib source #> anytime 0.3.6 2019-08-29 [1] CRAN (R 3.6.1) #> assertthat 0.2.1 2019-03-21 [3] CRAN (R 3.5.3) #> backports 1.1.5 2019-10-02 [1] CRAN (R 3.6.1) #> callr 3.3.2 2019-09-22 [1] CRAN (R 3.6.1) #> cli 1.1.0 2019-03-19 [3] CRAN (R 3.5.3) #> colorspace 1.4-1 2019-03-18 [3] CRAN (R 3.6.1) #> crayon 1.3.4 2017-09-16 [3] CRAN (R 3.5.0) #> curl 4.2 2019-09-24 [1] CRAN (R 3.6.1) #> desc 1.2.0 2018-05-01 [3] CRAN (R 3.5.0) #> devtools 2.2.1 2019-09-24 [1] CRAN (R 3.6.1) #> digest 0.6.22 2019-10-21 [1] CRAN (R 3.6.1) #> dplyr 0.8.3 2019-07-04 [3] CRAN (R 3.6.1) #> ellipsis 0.3.0 2019-09-20 [1] CRAN (R 3.6.1) #> evaluate 0.14 2019-05-28 [3] CRAN (R 3.6.0) #> expsmooth 2.4 2019-10-22 [1] Github (robjhyndman/expsmooth@d17dfde) #> fable * 0.1.0.9000 2019-11-07 [1] Github (tidyverts/fable@2ccd6c1) #> fabletools * 0.1.1.9000 2019-11-07 [1] Github (tidyverts/fabletools@80aa54b) #> feasts 0.1.1.9000 2019-10-23 [1] Github (tidyverts/feasts@47b7022) #> fma 2.4 2019-10-22 [1] Github (robjhyndman/fma@f65da7f) #> forecast 8.9.0.9000 2019-11-07 [1] Github (robjhyndman/forecast@b22067a) #> fpp2 2.3 2019-11-07 [1] Github (robjhyndman/fpp@3a1b96c) #> fracdiff 1.4-2 2012-12-02 [1] CRAN (R 3.6.1) #> fs 1.3.1 2019-05-06 [3] CRAN (R 3.6.1) #> generics 0.0.2 2018-11-29 [3] CRAN (R 3.5.1) #> ggplot2 3.2.1 2019-08-10 [1] CRAN (R 3.6.1) #> glue 1.3.1 2019-03-12 [3] CRAN (R 3.5.3) #> gtable 0.3.0 2019-03-25 [3] CRAN (R 3.6.1) #> highr 0.8 2019-03-20 [3] CRAN (R 3.6.1) #> htmltools 0.4.0 2019-10-04 [1] CRAN (R 3.6.1) #> knitr 1.26 2019-11-12 [1] CRAN (R 3.6.1) #> lattice 0.20-38 2018-11-04 [4] CRAN (R 3.5.1) #> lazyeval 0.2.2 2019-03-15 [3] CRAN (R 3.5.3) #> lifecycle 0.1.0 2019-08-01 [1] CRAN (R 3.6.1) #> lmtest 0.9-37 2019-04-30 [1] CRAN (R 3.6.1) #> lubridate 1.7.4 2018-04-11 [3] CRAN (R 3.5.0) #> magrittr 1.5 2014-11-22 [3] CRAN (R 3.5.0) #> memoise 1.1.0 2017-04-21 [3] CRAN (R 3.5.0) #> munsell 0.5.0 2018-06-12 [3] CRAN (R 3.5.0) #> nlme 3.1-142 2019-11-07 [4] CRAN (R 3.6.1) #> nnet 7.3-12 2016-02-02 [4] CRAN (R 3.5.0) #> pillar 1.4.2 2019-06-29 [3] CRAN (R 3.6.1) #> pkgbuild 1.0.6 2019-10-09 [1] CRAN (R 3.6.1) #> pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 3.6.1) #> pkgload 1.0.2 2018-10-29 [1] CRAN (R 3.6.1) #> prettyunits 1.0.2 2015-07-13 [3] CRAN (R 3.5.0) #> processx 3.4.1 2019-07-18 [3] CRAN (R 3.6.1) #> ps 1.3.0 2018-12-21 [3] CRAN (R 3.5.2) #> purrr 0.3.3 2019-10-18 [1] CRAN (R 3.6.1) #> quadprog 1.5-7 2019-05-06 [1] CRAN (R 3.6.1) #> quantmod 0.4-15 2019-06-17 [1] CRAN (R 3.6.1) #> R6 2.4.0 2019-02-14 [3] CRAN (R 3.5.2) #> Rcpp 1.0.3 2019-11-08 [1] CRAN (R 3.6.1) #> remotes 2.1.0 2019-06-24 [1] CRAN (R 3.6.1) #> rlang 0.4.1 2019-10-24 [1] CRAN (R 3.6.1) #> rmarkdown 1.16.4 2019-11-12 [1] Github (rstudio/rmarkdown@1f63943) #> rprojroot 1.3-2 2018-01-03 [3] CRAN (R 3.5.0) #> scales 1.0.0 2018-08-09 [3] CRAN (R 3.5.1) #> sessioninfo 1.1.1 2018-11-05 [1] CRAN (R 3.6.1) #> stringi 1.4.3 2019-03-12 [3] CRAN (R 3.5.3) #> stringr 1.4.0 2019-02-10 [3] CRAN (R 3.5.2) #> testthat 2.3.0 2019-11-05 [1] CRAN (R 3.6.1) #> tibble 2.1.3 2019-06-06 [3] CRAN (R 3.6.0) #> tidyr 1.0.0 2019-09-11 [1] CRAN (R 3.6.1) #> tidyselect 0.2.5 2018-10-11 [3] CRAN (R 3.5.1) #> timeDate 3043.102 2018-02-21 [1] CRAN (R 3.6.1) #> tseries 0.10-47 2019-06-05 [1] CRAN (R 3.6.1) #> tsibble * 0.8.5 2019-11-03 [1] CRAN (R 3.6.1) #> TTR 0.23-5 2019-09-23 [1] CRAN (R 3.6.1) #> urca 1.3-0 2016-09-06 [1] CRAN (R 3.6.1) #> usethis 1.5.1 2019-07-04 [1] CRAN (R 3.6.1) #> vctrs 0.2.0 2019-07-05 [3] CRAN (R 3.6.1) #> withr 2.1.2 2018-03-15 [3] CRAN (R 3.5.0) #> xfun 0.11 2019-11-12 [1] CRAN (R 3.6.1) #> xts 0.11-2 2018-11-05 [1] CRAN (R 3.6.1) #> yaml 2.2.0 2018-07-25 [3] CRAN (R 3.5.1) #> zeallot 0.1.0 2018-01-28 [3] CRAN (R 3.5.0) #> zoo 1.8-6 2019-05-28 [1] CRAN (R 3.6.1) #> #> [1] /home/robjhyndman/R/x86_64-pc-linux-gnu-library/3.6 #> [2] /usr/local/lib/R/site-library #> [3] /usr/lib/R/site-library #> [4] /usr/lib/R/library ```
mitchelloharawild commented 4 years ago

First error: Fixed in 34529f4f0ac67e18f0d5a1afdc69d05fec2fb384

Second error: ARIMA(value) ~ PDQ(0,0,0) should be ARIMA(value ~ PDQ(0,0,0))