tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

accuracy() error: Can't combine `snaive` <lst_mdl> and `avg` <lst_mdl> #231

Closed ilebizard closed 4 years ago

ilebizard commented 4 years ago

Hello, I'm trying to run combine multiple models as follows: fitModel = tsVol_Train %>% model( snaive = SNAIVE(vol), trend_seas = TSLM(vol ~ trend() + fourier(K=26)),
ets = ETS(vol), arima = ARIMA(vol), arimax = ARIMA(vol ~ trend() + fourier(K=26)) ) %>% mutate(avg = (snaive + trend_seas + ets + arima + arimax)/5)

While fitting works: snaive trend_seas ets arima 1 <ETS(A,Ad,N)> <ARIMA(2,1,1)(0,1,0)[52]> arimax avg 1 <LM w/ ARIMA(0,0,0) errors>

fitModel %>% accuracy() produced error:

Error : Can't combine snaive and avg . Error : Can't combine snaive and avg . ✖ Some attributes are incompatible. ℹ The author of the class should implement vctrs methods.

Below is my sessionInfo() results: R version 3.6.0 (2019-04-26) Platform: x86_64-pc-linux-gnu (64-bit) Running under: Ubuntu 16.04.6 LTS

Matrix products: default BLAS: /usr/lib/openblas-base/libblas.so.3 LAPACK: /usr/lib/libopenblasp-r0.2.18.so

locale: [1] LC_CTYPE=en_US.UTF-8 LC_NUMERIC=C
[3] LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8
[5] LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8
[7] LC_PAPER=en_US.UTF-8 LC_NAME=C
[9] LC_ADDRESS=C LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] data.table_1.12.8 feasts_0.1.4 fable_0.2.1 fabletools_0.2.0
[5] tsibble_0.9.1.9000 forcats_0.4.0 stringr_1.4.0 dplyr_1.0.0
[9] purrr_0.3.4 readr_1.3.1 tidyr_1.1.0 tibble_3.0.1
[13] ggplot2_3.3.2 tidyverse_1.3.0 sparklyr_1.0.0 SparkR_2.4.3
[17] remotes_2.1.1

loaded via a namespace (and not attached): [1] tidyselect_1.1.0 forge_0.2.0 haven_2.3.1
[4] lattice_0.20-38 colorspace_1.4-1 vctrs_0.3.1
[7] generics_0.0.2 htmltools_0.3.6 base64enc_0.1-3
[10] blob_1.2.1 rlang_0.4.6 pillar_1.4.4
[13] glue_1.4.1 withr_2.1.2 DBI_1.0.0
[16] Rserve_1.8-6 dbplyr_1.4.4 distributional_0.1.0 [19] modelr_0.1.8 readxl_1.3.1 lifecycle_0.2.0
[22] anytime_0.3.7 munsell_0.5.0 gtable_0.3.0
[25] cellranger_1.1.0 rvest_0.3.5 htmlwidgets_1.3
[28] curl_3.3 fansi_0.4.1 broom_0.5.6
[31] r2d3_0.2.3 Rcpp_1.0.4.6 backports_1.1.3
[34] scales_1.1.1 jsonlite_1.6 farver_2.0.3
[37] fs_1.2.7 hms_0.5.3 digest_0.6.25
[40] stringi_1.4.3 grid_3.6.0 rprojroot_1.3-2
[43] cli_2.0.2 tools_3.6.0 magrittr_1.5
[46] crayon_1.3.4 pkgconfig_2.0.3 ellipsis_0.3.1
[49] xml2_1.3.2 reprex_0.3.0 lubridate_1.7.9
[52] assertthat_0.2.1 httr_1.4.1 rstudioapi_0.10
[55] R6_2.4.1 nlme_3.1-140 compiler_3.6.0

Can you please have a look?

Thank you, Nguyen

mitchelloharawild commented 4 years ago

This should now be fixed.