search

tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

Rework model definitions #327

Open mitchelloharawild opened 2 years ago

mitchelloharawild commented 2 years ago

The current system of reusing a single R6 class for each slice of the data (key) has a few issues:

  1. Cannot easily choose models by row (https://github.com/tidyverts/fable/issues/54)
  2. More overhead for model setup
  3. Has been the cause of a few bugs (https://github.com/tidyverts/fabletools/issues/326)

Setting up a simpler model structure that can be vectorised with vctrs may help here.