decomposition_model fail when using classical_decomposition

tidyverts / fabletools

General fable features useful for extension packages

http://fabletools.tidyverts.org/

89 stars 31 forks source link

Closed robjhyndman closed 7 months ago

robjhyndman commented 7 months ago

MRE:

as_tsibble(USAccDeaths) |> 
  model(decomposition_model(
  classical_decomposition(value, type = "additive"),
  NAIVE(season_adjust)
))

mitchelloharawild commented 7 months ago

Also requires latest feasts fix in https://github.com/tidyverts/feasts/commit/2823121a73ff4b5e840c7df8844da73c2b8fd07c The specification of the seasonally adjusted variable's structure wasn't appropriate - correct, but not suitable for the software design.