search

tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

Use ggdist::ramp_colours in ggdist > 3.3.1 #397

Closed mjskay closed 4 months ago

mjskay commented 4 months ago

Hi @mitchelloharawild --- I am preparing to make a new release of {ggdist} this week, partly to fix some minor issues due to the new release of {ggplot2}. During revdep checks I found a minor issue in {fabletools}.

As I am sure you discovered, colour ramps produced by {ggdist} were previously just a list type with attributes, and the method for applying them was not exported. The new version of {ggdist} now uses a proper datatype to represent partial colour ramps produced by the colour_ramp and fill_ramp scales, and exports a function, ggdist::ramp_colours(), for applying them. As a result, the old approach for translating colour ramps into colour no longer works and needs to be updated here, which this PR does.

mjskay commented 4 months ago

@mitchelloharawild pinging again --- I'd like to do a CRAN submission soon on this, ideally in the next week, because I don't want to leave some parts of {ggdist} not working properly in the CRAN version. When that happens I believe some {fabletools} tests will break on CRAN unless this issue is fixed.

mitchelloharawild commented 4 months ago

Thanks for the bump, I'll prepare a CRAN patch asap.

mjskay commented 4 months ago

Thanks much!

mitchelloharawild commented 4 months ago

On CRAN now :tada:

mjskay commented 4 months ago

Sweet, thanks for the quick response! 🎉