search

tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

nest() and unnest() need updating #69

Closed earowang closed 5 years ago

earowang commented 5 years ago

tidyr v1.0.0 will hit on CRAN before useR. nest() & unnest() interfaces have changed a bit. Will likely trigger warnings/messages, for example https://github.com/tidyverts/fablelite/blob/7b545ca3385f0e15e26644ddcc806e87f7d5e9d3/R/accuracy.R#L205

Please see the up-to-date docs https://tidyr.tidyverse.org/dev/reference/nest.html

mitchelloharawild commented 5 years ago

Big performance gains from making this change, especially. Thanks! :+1: