Are generics appropriate for scoped variants of features()

tidyverts / fabletools

General fable features useful for extension packages

http://fabletools.tidyverts.org/

89 stars 31 forks source link

Are generics appropriate for scoped variants of features() #78

Closed mitchelloharawild closed 5 years ago

mitchelloharawild commented 5 years ago

@earowang Thinking about this more, why shouldn't the scoped variants be s3 generics? You could define the .default method as something reasonable, but if they were s3 it would allow you to more easily not include key/index variables in summarise_all.

Moved from https://github.com/tidyverts/fablelite/issues/76