tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

Partial feature tagging #82

Closed mitchelloharawild closed 5 years ago

mitchelloharawild commented 5 years ago

@earowang

Some features like features_stl return elements of different tags ("trend" and "seasonality"). Is it reasonable to allow feature registration to define tags for individual values of the output? That way feature_set(tag = "seasonality") would match features_stl but only return the computed values that are relevant to seasonality.

This may be difficult to implement, as the output of many features are not length stable.

earowang commented 5 years ago

Only functions can own tags.

mitchelloharawild commented 5 years ago

So is that a no? Keep things simple and have tags match entire feature functions?

earowang commented 5 years ago

Nope. If vector names follow standardised and good-practice naming, surely contains(season) is more intuitive to extract the features after computing. It's easy to look up functions not returned names.