search

tidyverts / fabletools

General fable features useful for extension packages
http://fabletools.tidyverts.org/
89 stars 31 forks source link

Argument uses full name instead of abbreviation #94

Closed earowang closed 5 years ago

earowang commented 5 years ago

It seems using abbreviation for arguments doesn't have much efficiency gain, can we change them to responses (looks like it accepts a list of variables?) and distribution.

https://github.com/tidyverts/fablelite/blob/76a68abcbb59fffbdadee3d2a7843186edfe76b3/R/fable.R#L43

I feel like these arguments should belong to the generic as well as the tbl_ts method.