gg_season() for annual data

[earowang]

Should the series of 1821 start at 0 instead of 21?

library(feasts)
#> Loading required package: fabletools
lynx_tsbl <- as_tsibble(lynx)
gg_season(lynx_tsbl, value, period = "40 year")

forecast::seasonplot(lynx, 40, type = "l")
#> Registered S3 method overwritten by 'quantmod':
#>   method            from
#>   as.zoo.data.frame zoo

^{Created on 2020-07-27 by the reprex package (v0.3.0)}

[robjhyndman]

I think it is simpler to interpret when starting at 1.

[mitchelloharawild]

Yes, it should start at 1.

On Mon., 27 Jul. 2020, 15:25 Rob J Hyndman, notifications@github.com wrote:

I think it is simpler to interpret when starting at 1.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tidyverts/feasts/issues/111#issuecomment-664126324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3BJFYG5HZG5JO6TA4UZTLR5UFTRANCNFSM4PILZCEA .

[mitchelloharawild]

library(feasts)
#> Loading required package: fabletools
lynx_tsbl <- as_tsibble(lynx)
gg_season(lynx_tsbl, value, period = "40 year")

^{Created on 2020-07-28 by the reprex package (v0.3.0)}

[earowang]

The x-axis values are not expected, akin to other relevant issues.

Cheers, Earo

On 29 Jul 2020, at 1:46, mitchelloharawild wrote:

library(feasts)
#> Loading required package: fabletools
lynx_tsbl <- as_tsibble(lynx)
gg_season(lynx_tsbl, value, period = "40 year")

^{Created on 2020-07-28 by the reprex package (v0.3.0)}

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/tidyverts/feasts/issues/111#issuecomment-665050123