search

tidyverts / feasts

Feature Extraction And Statistics for Time Series
https://feasts.tidyverts.org/
291 stars 23 forks source link

unitroot_nsdiffs() is misnamed #119

Closed robjhyndman closed 3 years ago

robjhyndman commented 3 years ago

It does not use unit roots for the number of seasonal differences.

mitchelloharawild commented 3 years ago

unitroot_nsdiffs() provides the repeated testing procedure for identifying the number of differences required to achieve stationarity. It doesn't enforce the seasonal strength test to be used, however the default is based on the seasonal strength.

I think some clarification regarding the default test for unitroot_nsdiffs() is required, and some guidance on using alternative tests.