Warnings in ACF

[robjhyndman]

library(feasts)
#> Loading required package: fabletools
ACF(tsibble::tourism, Trips)
#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes

#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes

#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes

[mitchelloharawild]

I cannot reproduce this issue, could you post your sessionInfo()? reprex::reprex(si = TRUE)

[robjhyndman]

library(feasts)
#> Loading required package: fabletools
ACF(tsibble::tourism, Trips)
#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes

#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes

#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes

#> Warning in mutate_impl(.data, dots, caller_env()): Vectorizing 'cf_lag'
#> elements may not preserve their attributes
#> # A tsibble: 5,776 x 5 [1]
#> # Key:       Region, State, Purpose [304]
#>    Region   State           Purpose    lag     acf
#>    <chr>    <chr>           <chr>    <int>   <dbl>
#>  1 Adelaide South Australia Business     1  0.0333
#>  2 Adelaide South Australia Business     2  0.0590
#>  3 Adelaide South Australia Business     3  0.0536
#>  4 Adelaide South Australia Business     4  0.201 
#>  5 Adelaide South Australia Business     5  0.0645
#>  6 Adelaide South Australia Business     6  0.104 
#>  7 Adelaide South Australia Business     7 -0.0556
#>  8 Adelaide South Australia Business     8  0.227 
#>  9 Adelaide South Australia Business     9  0.0128
#> 10 Adelaide South Australia Business    10 -0.114 
#> # … with 5,766 more rows

^{Created on 2019-08-30 by the reprex package (v0.3.0)}

Session info

``` r devtools::session_info() #> ─ Session info ────────────────────────────────────────────────────────── #> setting value #> version R version 3.6.1 (2019-07-05) #> os Ubuntu 18.04.3 LTS #> system x86_64, linux-gnu #> ui X11 #> language en_GB #> collate en_AU.UTF-8 #> ctype en_AU.UTF-8 #> tz Australia/Melbourne #> date 2019-08-30 #> #> ─ Packages ────────────────────────────────────────────────────────────── #> package * version date lib #> anytime 0.3.5 2019-07-28 [1] #> assertthat 0.2.1 2019-03-21 [3] #> backports 1.1.4 2019-04-10 [3] #> callr 3.3.1 2019-07-18 [1] #> cli 1.1.0 2019-03-19 [3] #> colorspace 1.4-1 2019-03-18 [3] #> crayon 1.3.4 2017-09-16 [3] #> desc 1.2.0 2018-05-01 [1] #> devtools 2.1.0 2019-07-06 [1] #> digest 0.6.20 2019-07-04 [1] #> dplyr 0.8.3 2019-07-04 [1] #> evaluate 0.14 2019-05-28 [1] #> fabletools * 0.1.0.9000 2019-08-28 [1] #> fansi 0.4.0 2018-10-05 [3] #> feasts * 0.1.0 2019-08-28 [1] #> fs 1.3.1 2019-05-06 [1] #> generics 0.0.2 2018-11-29 [3] #> ggplot2 3.2.1 2019-08-10 [1] #> glue 1.3.1 2019-03-12 [3] #> gtable 0.3.0 2019-03-25 [3] #> highr 0.8 2019-03-20 [3] #> htmltools 0.3.6 2017-04-28 [3] #> knitr 1.24.2 2019-08-27 [1] #> lazyeval 0.2.2 2019-03-15 [3] #> lifecycle 0.1.0 2019-08-01 [1] #> lubridate 1.7.4 2018-04-11 [3] #> magrittr 1.5 2014-11-22 [3] #> memoise 1.1.0 2017-04-21 [3] #> munsell 0.5.0 2018-06-12 [3] #> pillar 1.4.2 2019-06-29 [1] #> pkgbuild 1.0.5 2019-08-26 [1] #> pkgconfig 2.0.2 2018-08-16 [3] #> pkgload 1.0.2 2018-10-29 [1] #> prettyunits 1.0.2 2015-07-13 [3] #> processx 3.4.1 2019-07-18 [1] #> ps 1.3.0 2018-12-21 [3] #> purrr 0.3.2 2019-03-15 [3] #> R6 2.4.0 2019-02-14 [3] #> Rcpp 1.0.2 2019-07-25 [1] #> remotes 2.1.0 2019-06-24 [1] #> rlang 0.4.0 2019-06-25 [1] #> rmarkdown 1.15.1 2019-08-28 [1] #> rprojroot 1.3-2 2018-01-03 [1] #> scales 1.0.0 2018-08-09 [3] #> sessioninfo 1.1.1 2018-11-05 [1] #> stringi 1.4.3 2019-03-12 [3] #> stringr 1.4.0 2019-02-10 [3] #> testthat 2.2.1 2019-07-25 [1] #> tibble 2.1.3 2019-06-06 [1] #> tidyr 0.8.99.9000 2019-08-30 [1] #> tidyselect 0.2.5 2018-10-11 [3] #> tsibble 0.8.3 2019-07-29 [1] #> usethis 1.5.1 2019-07-04 [1] #> utf8 1.1.4 2018-05-24 [3] #> vctrs 0.2.0 2019-07-05 [1] #> withr 2.1.2 2018-03-15 [3] #> xfun 0.9 2019-08-21 [1] #> yaml 2.2.0 2018-07-25 [3] #> zeallot 0.1.0 2018-01-28 [1] #> source #> CRAN (R 3.6.1) #> CRAN (R 3.5.3) #> CRAN (R 3.5.3) #> CRAN (R 3.6.1) #> CRAN (R 3.5.3) #> CRAN (R 3.5.3) #> CRAN (R 3.5.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> Github (tidyverts/fabletools@7979378) #> CRAN (R 3.5.1) #> Github (tidyverts/feasts@fa624cf) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.1) #> CRAN (R 3.5.3) #> CRAN (R 3.5.3) #> CRAN (R 3.5.3) #> CRAN (R 3.5.0) #> Github (yihui/knitr@2dee8f4) #> CRAN (R 3.5.3) #> CRAN (R 3.6.1) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.5.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.0) #> CRAN (R 3.6.1) #> CRAN (R 3.5.2) #> CRAN (R 3.5.3) #> CRAN (R 3.5.2) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> Github (rstudio/rmarkdown@f7b37c5) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.3) #> CRAN (R 3.5.2) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> Github (tidyverse/tidyr@50a0c1a) #> CRAN (R 3.5.1) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.0) #> CRAN (R 3.6.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> #> [1] /home/hyndman/R/x86_64-pc-linux-gnu-library/3.6 #> [2] /usr/local/lib/R/site-library #> [3] /usr/lib/R/site-library #> [4] /usr/lib/R/library ```

[robjhyndman]

The lag is also not 1Q any more. Related?

[mitchelloharawild]

Yes, the text formatting is dependent on the class which is being dropped (as stated in the warning).

[earowang]

Actually is the custom class cf_lag needed? I can't see the advantage of using cf_lag rather than difftime as the lag variable.

[mitchelloharawild]

It's used for a ggplot scale which has seasonality specific plot breaks. I could probably add it to the autoplot method instead, I'll have a think about it.

[mitchelloharawild]

Closing as I am unable to reproduce this issue. Class of *CF lag index is moved to issue #82